fix(gooddata-eval): treat alert proposal part as confirmation signal - #1699
Merged
Conversation
JIRA: QA-28774 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
myhoai
enabled auto-merge
July 31, 2026 02:36
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAlert proposals now flow through SSE parsing, ChangesAlert proposal flow
uv installation configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant SSEClient
participant ChatResult
participant ConversationLoop
participant render_alert_proposal
participant SimulatedUser
participant AlertCreation
SSEClient->>ChatResult: Provide alertProposals
ChatResult->>ConversationLoop: Provide proposal-only response
ConversationLoop->>render_alert_proposal: Render latest proposal
render_alert_proposal->>SimulatedUser: Send proposal text and CTA
SimulatedUser->>ConversationLoop: Return confirmation
ConversationLoop->>AlertCreation: Create metric alert
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/gooddata-eval/src/gooddata_eval/core/agentic/alert_skill.py`:
- Around line 329-330: Update the alert handling around the proposal processing
so summary["alert"] is assigned whenever the proposal contains an alert,
including after execution is removed and the alert becomes empty; do not gate
the assignment on alert truthiness. Add a regression case covering an alert
containing only {"execution": {...}} and verify the resulting summary omits the
execution payload.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42c63366-50ac-425e-8c43-d993aa8026fb
📒 Files selected for processing (7)
packages/gooddata-eval/src/gooddata_eval/core/agentic/alert_skill.pypackages/gooddata-eval/src/gooddata_eval/core/agentic/conversation.pypackages/gooddata-eval/src/gooddata_eval/core/chat/sse_client.pypackages/gooddata-eval/src/gooddata_eval/core/models.pypackages/gooddata-eval/tests/test_agentic_alert_skill.pypackages/gooddata-eval/tests/test_agentic_conversation.pypackages/gooddata-eval/tests/test_sse_client.py
… field JIRA: QA-28774 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Unrelated to the rest of this PR; unblocks `unit-tests`, which every Python-changing PR now hits. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1699 +/- ##
==========================================
+ Coverage 78.05% 78.30% +0.24%
==========================================
Files 271 271
Lines 18676 18689 +13
==========================================
+ Hits 14578 14634 +56
+ Misses 4098 4055 -43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrynguyengooddata
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: QA-28774
Summary by CodeRabbit
New Features
Bug Fixes
Tests